Prioritize pods on unschedulable nodes #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an optimization to prioritize pods on nodes which are marked unschedulable higher than pods on schedulable nodes. Unschedulable nodes indicate that the node is being drained, so it makes sense to move those pods as soon as possible. Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
|
👍 |
otrosien
reviewed
Apr 30, 2019
operator/operator.go
Outdated
| @@ -506,12 +506,12 @@ func (o *Operator) getPodToUpdate(pods []v1.Pod, sts *appsv1.StatefulSet, sr Sta | |||
| return nil, nil | |||
| } | |||
|
|
|||
| prioritizedNodes, err := o.getPrioritizedNodes() | |||
| prioritizedNodes, cordonedNodes, err := o.getNodes() | |||
There was a problem hiding this comment.
wouldn't it make sense to unify the naming cordoned vs. unschedulable?
There was a problem hiding this comment.
Yes, changed it to unscheduled midway through the change, forgot to change this variable..
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optimization to prioritize pods on nodes which are marked
unschedulable higher than pods on schedulable nodes. Unschedulable nodes
indicate that the node is being drained, so it makes sense to move those
pods as soon as possible.